lkml.org 
[lkml]   [2023]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v1] drivers: pci: introduce configurable delay for Rockchip PCIe bus scan
    On Tue, May 09, 2023 at 05:39:12PM +0200, Vincenzo Palazzo wrote:
    > --- a/drivers/pci/controller/pcie-rockchip-host.c
    > +++ b/drivers/pci/controller/pcie-rockchip-host.c
    > @@ -38,6 +38,10 @@
    > #include "../pci.h"
    > #include "pcie-rockchip.h"
    >
    > +/* bus_scan_delay - module parameter to override the
    > + * device tree value, which is 0 by default. */
    > +static int bus_scan_delay = -1;

    Please do not add new module parameters, this is not the 1990's anymore.
    We have per-device settings everywhere, this makes that impossible.
    Just use a DT value, if it is wrong, then fix the DT value! No need to
    have the kernel override it, that's not what DT files are for.

    thanks,

    greg k-h

    \
     
     \ /
      Last update: 2023-05-10 09:58    [W:8.361 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site