Messages in this thread | | | Date | Wed, 10 May 2023 08:13:58 +0100 | From | Conor Dooley <> | Subject | Re: [PATCH 1/2] RISC-V: lib: Improve memset assembler formatting |
| |
Hey Zhangfei,
On Wed, May 10, 2023 at 11:52:41AM +0800, zhangfei wrote: > From: Andrew Jones <ajones@ventanamicro.com> > > Aligning the first operand of each instructions with a tab is a > typical style which improves readability. Apply it to memset.S. > While there, we also make a small grammar change to a comment. > > No functional change intended. > > Signed-off-by: Andrew Jones <ajones@ventanamicro.com> > Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Three things for you here.. Firstly, since you sent Andrew's work, you need to add your own Signed-off-by to the patch. Secondly & thirdly, please version your patchsets & do not later versions as an reply to the v1. In my mail client I see:
May 10 zhangfei ( 58) ┌─>[PATCH 2/2] riscv: Optimize memset May 10 Andrew Jones ( 36) │ ┌─> May 10 zhangfei ( 32) ├─>Re: [PATCH] riscv: Optimize memset May 10 zhangfei ( 205) ├─>[PATCH 1/2] RISC-V: lib: Improve memset assembler formatting May 10 zhangfei ( 56) ┌─>[PATCH 0/2] riscv: Optimize memset for data sizes less than 16 bytes May 09 Andrew Jones ( 87) ┌─>Re: [PATCH] riscv: Optimize memset May 09 zhangfei ( 67) ┌─>Re: Re: [PATCH] riscv: Optimize memset May 09 Andrew Jones ( 211) ├─>Re: [PATCH 1/2] RISC-V: lib: Improve memset assembler formatting May 09 zhangfei ( 57) ├─>[PATCH 2/2] riscv: Optimize memset May 09 zhangfei ( 204) ┌─>[PATCH 1/2] RISC-V: lib: Improve memset assembler formatting May 05 Andrew Jones ( 91) ┌─> May 05 张飞 ( 38) [PATCH] riscv: Optimize memset
How am I supposed to know what is what there?
Thanks, Conor. [unhandled content-type:application/pgp-signature] | |