Messages in this thread | | | Date | Mon, 1 May 2023 10:52:06 -0500 | Subject | Re: [PATCH v2 2/4] dt-bindings: net: can: Add poll-interval for MCAN | From | "Mendez, Judith" <> |
| |
Hello Krzysztof,
On 5/1/2023 2:16 AM, Krzysztof Kozlowski wrote: > On 28/04/2023 18:17, Mendez, Judith wrote: >> Hello Rob, >> >> On 4/24/2023 7:13 PM, Rob Herring wrote: >>> >>> On Mon, 24 Apr 2023 14:54:00 -0500, Judith Mendez wrote: >>>> On AM62x SoC, MCANs on MCU domain do not have hardware interrupt >>>> routed to A53 Linux, instead they will use software interrupt by >>>> hrtimer. To enable timer method, interrupts should be optional so >>>> remove interrupts property from required section and introduce >>>> poll-interval property. >>>> >>>> Signed-off-by: Judith Mendez <jm@ti.com> >>>> --- >>>> Changelog: >>>> v2: >>>> 1. Add poll-interval property to enable timer polling method >>>> 2. Add example using poll-interval property >>>> >>>> .../bindings/net/can/bosch,m_can.yaml | 26 ++++++++++++++++--- >>>> 1 file changed, 23 insertions(+), 3 deletions(-) >>>> >>> >>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' >>> on your patch (DT_CHECKER_FLAGS is new in v5.13): >>> >>> yamllint warnings/errors: >>> >>> dtschema/dtc warnings/errors: >>> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml: 'example with interrupts' is not one of ['$id', '$schema', 'title', 'description', 'examples', 'required', 'allOf', 'anyOf', 'oneOf', 'definitions', '$defs', 'additionalProperties', 'dependencies', 'dependentRequired', 'dependentSchemas', 'patternProperties', 'properties', 'not', 'if', 'then', 'else', 'unevaluatedProperties', 'deprecated', 'maintainers', 'select', '$ref'] >>> from schema $id: http://devicetree.org/meta-schemas/base.yaml# >>> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml: 'example with timer polling' is not one of ['$id', '$schema', 'title', 'description', 'examples', 'required', 'allOf', 'anyOf', 'oneOf', 'definitions', '$defs', 'additionalProperties', 'dependencies', 'dependentRequired', 'dependentSchemas', 'patternProperties', 'properties', 'not', 'if', 'then', 'else', 'unevaluatedProperties', 'deprecated', 'maintainers', 'select', '$ref'] >>> from schema $id: http://devicetree.org/meta-schemas/base.yaml# >>> >>> doc reference errors (make refcheckdocs): >>> >>> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230424195402.516-3-jm@ti.com >>> >>> The base for the series is generally the latest rc1. A different dependency >>> should be noted in *this* patch. >>> >>> If you already ran 'make dt_binding_check' and didn't see the above >>> error(s), then make sure 'yamllint' is installed and dt-schema is up to >>> date: >>> >>> pip3 install dtschema --upgrade >>> >>> Please check and re-submit after running the above command yourself. Note >>> that DT_SCHEMA_FILES can be set to your schema file to speed up checking >>> your schema. However, it must be unset to test all examples with your schema. >> >> Thanks Rob, I was not getting the errors, but I have fixed now. Thanks. > > There is no way your code have worked, so either you did not test it or > your setup misses something. In both cases you would see errors, so > please check what went wrong.
Will do, thanks for taking the time to check the patch for errors.
regards, Judith
| |