Messages in this thread | | | Date | Sat, 8 Apr 2023 17:04:08 +0530 | Subject | Re: [PATCH RFC v2 1/2] irqchip: irq-ti-sci-inta: Allocates VINTs at probe | From | "Raghavendra, Vignesh" <> |
| |
On 4/8/2023 4:09 PM, Marc Zyngier wrote: > On Mon, 27 Mar 2023 16:04:26 +0100, > Vignesh Raghavendra <vigneshr@ti.com> wrote: >> >> Simplify driver by allocating all VINTs at probe instead of >> allocating on IRQ request. This will allow dedicating few VINTs as >> direct IRQs without aggregation in future. > > I think this is going in the wrong direction. Eager allocation is > wasting memory, slowing down boot, and in general a bad idea. > > Why can't you just pre-allocate *one* interrupt that serves as a > chained handler for everything, and then use the rest of the interrupt > space for "direct" interrupts? >
I may need more than one (at least 2 or 3), but I get the point. Will rework accordingly.
Regards Vignesh
| |