Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 5 Apr 2023 19:23:55 +0200 | From | Greg KH <> | Subject | Re: [PATCH] usb: cdnsp: Fixes error: uninitialized symbol 'len' |
| |
On Fri, Mar 31, 2023 at 05:06:00AM -0400, Pawel Laszczak wrote: > The patch 5bc38d33a5a1: "usb: cdnsp: Fixes issue with redundant > Status Stage" leads to the following Smatch static checker warning: > > drivers/usb/cdns3/cdnsp-ep0.c:470 cdnsp_setup_analyze() > error: uninitialized symbol 'len'.
Are you sure this is correct?
> > cc: <stable@vger.kernel.org> > Fixes: 5bc38d33a5a1 ("usb: cdnsp: Fixes issue with redundant Status Stage") > Signed-off-by: Pawel Laszczak <pawell@cadence.com> > --- > drivers/usb/cdns3/cdnsp-ep0.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/usb/cdns3/cdnsp-ep0.c b/drivers/usb/cdns3/cdnsp-ep0.c > index d63d5d92f255..f317d3c84781 100644 > --- a/drivers/usb/cdns3/cdnsp-ep0.c > +++ b/drivers/usb/cdns3/cdnsp-ep0.c > @@ -414,7 +414,7 @@ static int cdnsp_ep0_std_request(struct cdnsp_device *pdev, > void cdnsp_setup_analyze(struct cdnsp_device *pdev) > { > struct usb_ctrlrequest *ctrl = &pdev->setup; > - int ret = 0; > + int ret = -EINVAL; > u16 len; > > trace_cdnsp_ctrl_req(ctrl); > @@ -424,7 +424,6 @@ void cdnsp_setup_analyze(struct cdnsp_device *pdev) > > if (pdev->gadget.state == USB_STATE_NOTATTACHED) { > dev_err(pdev->dev, "ERR: Setup detected in unattached state\n"); > - ret = -EINVAL;
That's a nice change, but I don't see the original error here that you are saying this change fixes.
What am I missing?
thanks,
greg k-h
| ![\](/images/icornerr.gif) |