Messages in this thread | | | Date | Tue, 4 Apr 2023 11:19:53 +0200 | From | Michal Koutný <> | Subject | Re: [PATCH 1/3] cgroup/cpuset: Make cpuset_fork() handle CLONE_INTO_CGROUP properly |
| |
On Mon, Apr 03, 2023 at 01:18:42PM -0400, Waiman Long <longman@redhat.com> wrote: > 1) PF_NO_SETAFFINITY flag - which won't be set in the case of fork() as it > is for kthread only. > 2) DL bandwidth - Juri has a cpuset outstanding to modify the way this check > is being done. I want to wait until it is settled before tackling this, if > necessary.
BTW what about CLONE_INTO_CGROUP where the target cpuset has empty effective cpuset?
> 3) security_task_setscheduler() - the CLONE_INTO_CGROUP code has already > checked that, we don't need to duplicate the check.
Not sure what this refers to.
> So we don't need a can_fork() check for now.
Anyway, good breakdown. Could you please add it to the commit message too?
Regards, Michal [unhandled content-type:application/pgp-signature] | |