Messages in this thread | | | Date | Mon, 3 Apr 2023 18:40:40 +0200 | From | Christian Brauner <> | Subject | Re: [PATCH v2] fs/buffer: Remove redundant assignment to err |
| |
On Mon, Apr 03, 2023 at 06:38:02PM +0200, Jan Kara wrote: > On Mon 03-04-23 18:10:43, Jan Kara wrote: > > On Thu 23-03-23 10:32:59, Jiapeng Chong wrote: > > > Variable 'err' set but not used. > > > > > > fs/buffer.c:2613:2: warning: Value stored to 'err' is never read. > > > > > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4589 > > > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > > > > I don't think the patch is quite correct (Christian, please drop it if I'm > > correct). See below: > > Ah, sorry. I had too old kernel accidentally checked out. The patch is fine > with current upstream. Sorry for the noise!
No problem at all. I'm very happy that you took the time to review this. This is very much needed!
Christian
| |