Messages in this thread | | | Date | Mon, 3 Apr 2023 18:28:53 +0300 | Subject | Re: [PATCH v1 3/3] msm: skip the atomic commit of self refresh while PSR running | From | Dmitry Baryshkov <> |
| |
On 31/03/2023 16:58, Vinod Polimera wrote: > In certain CPU stress conditions, there can be a delay in scheduling commit > work and it was observed that PSR commit from a different work queue was > scheduled. Avoid these commits as display is already in PSR mode. > > Signed-off-by: Vinod Polimera <quic_vpolimer@quicinc.com> > --- > drivers/gpu/drm/msm/msm_atomic.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/msm/msm_atomic.c b/drivers/gpu/drm/msm/msm_atomic.c > index 645fe53..f8141bb 100644 > --- a/drivers/gpu/drm/msm/msm_atomic.c > +++ b/drivers/gpu/drm/msm/msm_atomic.c > @@ -192,6 +192,9 @@ int msm_atomic_check(struct drm_device *dev, struct drm_atomic_state *state)
The corresponding patch is not yet applied. I wonder how this was tested.
> new_crtc_state->mode_changed = true; > state->allow_modeset = true; > } > + > + if (old_crtc_state->self_refresh_active && new_crtc_state->self_refresh_active) > + return -EINVAL; > } > > return drm_atomic_helper_check(dev, state);
-- With best wishes Dmitry
| |