Messages in this thread | | | Date | Mon, 3 Apr 2023 08:13:21 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH 2/2] block: Rework bio_for_each_folio_all() |
| |
On Mon, Mar 27, 2023 at 01:44:02PM -0400, Kent Overstreet wrote: > + bio_for_each_folio_all(fv, bio, iter) > + iomap_finish_folio_read(fv.fv_folio, fv.fv_offset, fv.fv_len, error);
Please avoid the overly long lines. Also if we pass all arguments of the folio_vec we might as ell just pass that folio_vec anyway.
> - BUG_ON(iter->idx > bio->bi_vcnt || (iter->idx == bio->bi_vcnt && iter->done)); > + BUG_ON(iter->idx > bio->bi_vcnt || > + (iter->idx == bio->bi_vcnt && iter->done));
Seems like this should be folded into the previous patch. Also I generally prefer to avoid top-level || in asserts and just do multiple asserts, as that shows which condition triggered.
| |