Messages in this thread | | | Date | Mon, 3 Apr 2023 19:47:17 +0800 | Subject | Re: [PATCH v2] mmc: core: remove unnecessary (void*) conversions | From | Yu Zhe <> |
| |
> On Tue, 28 Mar 2023 at 05:11, Yu Zhe <yuzhe@nfschina.com> wrote: >> Pointer variables of void * type do not require type cast. >> >> Signed-off-by: Yu Zhe <yuzhe@nfschina.com> >> Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com> > Did Marek give his reviewed-by tag offlist? I couldn't find his reply, > just to make sure this is correct? > > Kind regards > Uffe
Sorry, it may be a misuse of "reviewed-by" tag, "Marek Szyprowski" gave the error report at the previous patch, so, i put the name at reviewed-by tag.
> >> --- >> drivers/mmc/core/debugfs.c | 2 +- >> drivers/mmc/core/mmc_test.c | 6 +++--- >> 2 files changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/mmc/core/debugfs.c b/drivers/mmc/core/debugfs.c >> index fe6808771bc7..2c97b94aab23 100644 >> --- a/drivers/mmc/core/debugfs.c >> +++ b/drivers/mmc/core/debugfs.c >> @@ -246,7 +246,7 @@ DEFINE_DEBUGFS_ATTRIBUTE(mmc_err_state, mmc_err_state_get, NULL, "%llu\n"); >> >> static int mmc_err_stats_show(struct seq_file *file, void *data) >> { >> - struct mmc_host *host = (struct mmc_host *)file->private; >> + struct mmc_host *host = file->private; >> const char *desc[MMC_ERR_MAX] = { >> [MMC_ERR_CMD_TIMEOUT] = "Command Timeout Occurred", >> [MMC_ERR_CMD_CRC] = "Command CRC Errors Occurred", >> diff --git a/drivers/mmc/core/mmc_test.c b/drivers/mmc/core/mmc_test.c >> index 156d34b2ed4d..0f6a563103fd 100644 >> --- a/drivers/mmc/core/mmc_test.c >> +++ b/drivers/mmc/core/mmc_test.c >> @@ -3045,7 +3045,7 @@ static LIST_HEAD(mmc_test_file_test); >> >> static int mtf_test_show(struct seq_file *sf, void *data) >> { >> - struct mmc_card *card = (struct mmc_card *)sf->private; >> + struct mmc_card *card = sf->private; >> struct mmc_test_general_result *gr; >> >> mutex_lock(&mmc_test_lock); >> @@ -3079,8 +3079,8 @@ static int mtf_test_open(struct inode *inode, struct file *file) >> static ssize_t mtf_test_write(struct file *file, const char __user *buf, >> size_t count, loff_t *pos) >> { >> - struct seq_file *sf = (struct seq_file *)file->private_data; >> - struct mmc_card *card = (struct mmc_card *)sf->private; >> + struct seq_file *sf = file->private_data; >> + struct mmc_card *card = sf->private; >> struct mmc_test_card *test; >> long testcase; >> int ret; >> -- >> 2.11.0 >>
| |