Messages in this thread | | | Date | Mon, 3 Apr 2023 09:49:34 +0200 | Subject | Re: [PATCH 03/29] selftests/mm: Dump a summary in run_vmtests.sh | From | David Hildenbrand <> |
| |
On 31.03.23 00:28, Peter Xu wrote: > On Thu, Mar 30, 2023 at 12:07:24PM -0700, Axel Rasmussen wrote: >> On Thu, Mar 30, 2023 at 9:06 AM Peter Xu <peterx@redhat.com> wrote: >>> >>> Dump a summary after running whatever test specified. Useful for human >>> runners to identify any kind of failures (besides exit code). >>> >>> Signed-off-by: Peter Xu <peterx@redhat.com> >>> --- >>> tools/testing/selftests/mm/run_vmtests.sh | 8 ++++++++ >>> 1 file changed, 8 insertions(+) >>> >>> diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh >>> index c0f93b668c0c..9cc33984aa9f 100644 >>> --- a/tools/testing/selftests/mm/run_vmtests.sh >>> +++ b/tools/testing/selftests/mm/run_vmtests.sh >>> @@ -5,6 +5,9 @@ >>> # Kselftest framework requirement - SKIP code is 4. >>> ksft_skip=4 >>> >>> +count_pass=0 >>> +count_fail=0 >>> +count_skip=0 >>> exitcode=0 >>> >>> usage() { >>> @@ -149,11 +152,14 @@ run_test() { >>> "$@" >>> local ret=$? >>> if [ $ret -eq 0 ]; then >>> + count_pass=$(( $count_pass + 1 )) >> >> Actually, inside $(( )) there's no need to prefix variable names with >> $ too. Running "shellcheck" over the script written this way will >> generate a warning. >> >> Same applies below. > > Sure, I'll fix.
With that
Reviewed-by: David Hildenbrand <david@redhat.com>
-- Thanks,
David / dhildenb
| |