lkml.org 
[lkml]   [2023]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] soc: bcm: brcmstb: biuctrl: fix of_iomap leak
Date
On Mon, 27 Mar 2023 19:54:22 +0800, Zhaoyang Li <lizhaoyang04@hust.edu.cn> wrote:
> Smatch reports:
>
> drivers/soc/bcm/brcmstb/biuctrl.c:291 setup_hifcpubiuctrl_regs() warn:
> 'cpubiuctrl_base' from of_iomap() not released on lines: 291.
>
> This is because in setup_hifcpubiuctrl_regs(),
> cpubiuctrl_base is not released when handle error, which may cause a leak.
> To fix this, iounmap is added when handle error.
>
> Fixes: 22f7a9116eba ("soc: brcmstb: Correct CPU_CREDIT_REG offset for Brahma-B53 CPUs")
> Signed-off-by: Zhaoyang Li <lizhaoyang04@hust.edu.cn>
> Reviewed-by: Dan Carpenter <error27@gmail.com>
> Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
> ---

Applied to https://github.com/Broadcom/stblinux/commits/drivers/next, thanks!
--
Florian

\
 
 \ /
  Last update: 2023-04-03 22:38    [W:0.103 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site