Messages in this thread | | | From | Florian Fainelli <> | Subject | Re: [PATCH] soc: bcm: brcmstb: biuctrl: fix of_iomap leak | Date | Mon, 3 Apr 2023 13:37:25 -0700 |
| |
On Mon, 27 Mar 2023 19:54:22 +0800, Zhaoyang Li <lizhaoyang04@hust.edu.cn> wrote: > Smatch reports: > > drivers/soc/bcm/brcmstb/biuctrl.c:291 setup_hifcpubiuctrl_regs() warn: > 'cpubiuctrl_base' from of_iomap() not released on lines: 291. > > This is because in setup_hifcpubiuctrl_regs(), > cpubiuctrl_base is not released when handle error, which may cause a leak. > To fix this, iounmap is added when handle error. > > Fixes: 22f7a9116eba ("soc: brcmstb: Correct CPU_CREDIT_REG offset for Brahma-B53 CPUs") > Signed-off-by: Zhaoyang Li <lizhaoyang04@hust.edu.cn> > Reviewed-by: Dan Carpenter <error27@gmail.com> > Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn> > ---
Applied to https://github.com/Broadcom/stblinux/commits/drivers/next, thanks! -- Florian
| |