Messages in this thread | | | Date | Mon, 3 Apr 2023 13:51:17 -0500 | From | Rob Herring <> | Subject | Re: [PATCH V6 1/3] dt-bindings: nvmem: layouts: add fixed-layout |
| |
On Mon, 27 Mar 2023 16:16:09 +0200, Rafał Miłecki wrote: > From: Rafał Miłecki <rafal@milecki.pl> > > With the introduction of NVMEM layouts, new NVMEM content structures > should be defined as such. We should also try to convert / migrate > existing NVMEM content bindings to layouts. > > This commit handles fixed NVMEM cells. So far they had to be defined > directly - as device subnodes. With this change it's allowed to put them > in the DT node named "nvmem-layout". > > Having NVMEM cells in separated node is preferred as it draws a nice > line between NVMEM device and its content. It results in cleaner > bindings. > > FWIW a very similar situation has happened to MTD devices and their > partitions: see commit 5d96ea42eb63 ("dt-bindings: mtd: Clarify all > partition subnodes"). > > Signed-off-by: Rafał Miłecki <rafal@milecki.pl> > --- > V6: Add unevaluatedProperties: false > --- > .../bindings/nvmem/layouts/fixed-cell.yaml | 31 ++++++++++++ > .../bindings/nvmem/layouts/fixed-layout.yaml | 50 +++++++++++++++++++ > .../bindings/nvmem/layouts/nvmem-layout.yaml | 5 +- > .../devicetree/bindings/nvmem/nvmem.yaml | 19 +------ > 4 files changed, 84 insertions(+), 21 deletions(-) > create mode 100644 Documentation/devicetree/bindings/nvmem/layouts/fixed-cell.yaml > create mode 100644 Documentation/devicetree/bindings/nvmem/layouts/fixed-layout.yaml >
Reviewed-by: Rob Herring <robh@kernel.org>
| |