lkml.org 
[lkml]   [2023]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: [PATCH] powerpc: remove unneeded if-checks
Date


Le 29/04/2023 à 00:12, Tom Rix a écrit :
> For ppc64, gcc with W=1 reports
> arch/powerpc/platforms/cell/spu_base.c:330:17: error:
> suggest braces around empty body in an 'if' statement [-Werror=empty-body]
> 330 | ;
> | ^
> arch/powerpc/platforms/cell/spu_base.c:333:17: error:
> suggest braces around empty body in an 'if' statement [-Werror=empty-body]
> 333 | ;
> | ^
>
> These if-checks do not do anything so remove them.
>
> Signed-off-by: Tom Rix <trix@redhat.com>

Fixes: 67207b9664a8 ("[PATCH] spufs: The SPU file system, base")

Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>

> ---
> arch/powerpc/platforms/cell/spu_base.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/arch/powerpc/platforms/cell/spu_base.c b/arch/powerpc/platforms/cell/spu_base.c
> index 7bd0b563e163..dea6f0f25897 100644
> --- a/arch/powerpc/platforms/cell/spu_base.c
> +++ b/arch/powerpc/platforms/cell/spu_base.c
> @@ -326,12 +326,6 @@ spu_irq_class_1(int irq, void *data)
> if (stat & CLASS1_STORAGE_FAULT_INTR)
> __spu_trap_data_map(spu, dar, dsisr);
>
> - if (stat & CLASS1_LS_COMPARE_SUSPEND_ON_GET_INTR)
> - ;
> -
> - if (stat & CLASS1_LS_COMPARE_SUSPEND_ON_PUT_INTR)
> - ;
> -
> spu->class_1_dsisr = 0;
> spu->class_1_dar = 0;
>
\
 
 \ /
  Last update: 2023-04-29 08:26    [W:0.054 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site