lkml.org 
[lkml]   [2023]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86/show_trace_log_lvl: ensure stack pointer is aligned, again
On 04/28, Josh Poimboeuf wrote:
>
> On Fri, Apr 28, 2023 at 08:55:13AM +0200, Oleg Nesterov wrote:
> >
> > We decided to make the simplest one-liner fix, but I was thinking about
> >
> > for ( stack = stack ?: get_stack_pointer(task, regs);
> > (stack = PTR_ALIGN(stack, sizeof(long)));
> > stack = stack_info.next_sp)
> > {
> > ...
> >
> > to factout out the annoying PTR_ALIGN(). Will it work for you?
>
> I'd rather not, that's a little *too* clever, IMO.

To me

for (stack = PTR_ALIGN(stack ?: get_stack_pointer(task, regs), sizeof(long));
stack;
stack = PTR_ALIGN(stack_info.next_sp, sizeof(long)))

certainly looks less readable (and more "clever" ;) but I won't argue with
maintainer. Please see V2.

Oleg.

\
 
 \ /
  Last update: 2023-04-29 12:10    [W:0.089 / U:0.608 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site