Messages in this thread | | | From | "Zhijian Li (Fujitsu)" <> | Subject | Re: [RFC PATCH v2 3/3] resource, crash: Make kexec_file_load support pmem | Date | Fri, 28 Apr 2023 07:36:22 +0000 |
| |
Greg,
Sorry for these *BAD* changelog, This patch is most like a *HACKing* to resource.c currently. Please allow me to rewrite it once.
Only the region described by PT_LOADs of /proc/vmcore are dumpable/readble by dumping applications. Previously, on x86/x86_64 only system ram resources will be injected into PT_LOADs.
So in order to make the entire pmem resource is dumpable/readable, we need to add pmem region into the PT_LOADs of /proc/vmcore.
Here we introduce a new API walk_pmem_res() to walk the pmem region first. Further, we will also mark pmem region with extra p_flags PF_DEV when it's adding into PT_LOADs. Then the dumping applications are able to know if the region is pmem or not according this flag and take special actions correspondingly.
Thanks Zhijian
On 27/04/2023 19:39, Greg Kroah-Hartman wrote: > On Thu, Apr 27, 2023 at 06:18:34PM +0800, Li Zhijian wrote: >> It does: >> 1. Add pmem region into PT_LOADs of vmcore >> 2. Mark pmem region's p_flags as PF_DEV > > I'm sorry, but I can not parse this changelog. > > Please take a look at the kernel documentation for how to write a good > changelog message so that we can properly review the change you wish to > have accepted. > > thanks, > > greg k-h | |