Messages in this thread | | | Date | Fri, 28 Apr 2023 17:14:36 -0700 | Subject | Re: [PATCH v3 01/15] dmaengine: idxd: add wq driver name support for accel-config user tool | From | Fenghua Yu <> |
| |
Hi, Tom,
On 4/28/23 13:55, Tom Zanussi wrote: > From: Dave Jiang <dave.jiang@intel.com> > > With the possibility of multiple wq drivers that can be bound to the wq, > the user config tool accel-config needs a way to know which wq driver to > bind to the wq. Introduce per wq driver_name sysfs attribute where the user > can indicate the driver to be bound to the wq. This allows accel-config to > just bind to the driver using wq->driver_name. > > Signed-off-by: Dave Jiang <dave.jiang@intel.com> > Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com> > ---
...
> diff --git a/drivers/dma/idxd/idxd.h b/drivers/dma/idxd/idxd.h > index 7ced8d283d98..505118fc19de 100644 > --- a/drivers/dma/idxd/idxd.h > +++ b/drivers/dma/idxd/idxd.h > @@ -214,6 +214,8 @@ struct idxd_wq { > char name[WQ_NAME_SIZE + 1]; > u64 max_xfer_bytes; > u32 max_batch_size; > + > + char driver_name[WQ_NAME_SIZE + 1];
It's confused to use "WQ_NAME_SIZE" for driver name size. Maybe it's better to have a new definition "DRIVER_NAME_SIZE"? BTW, WQ_NAME_SIZE is 1024 which is unnecessary big for storing driver_name[] in the structure. It would be better to have a smaller size (e.g. 128) in DRIVER_NAME_SIZE.
Thanks.
-Fenghua
| |