Messages in this thread | | | Subject | Re: [PATCH v1] selftests/bpf: Do not use sign-file as testcase | From | Roberto Sassu <> | Date | Fri, 28 Apr 2023 09:14:44 +0200 |
| |
On Thu, 2023-04-27 at 11:28 -0700, Stanislav Fomichev wrote: > On 04/27, Alexey Gladkov wrote: > > The sign-file utility (from scripts/) is used in prog_tests/verify_pkcs7_sig.c, > > but the utility should not be called as a test. Executing this utility > > produces the following error: > > > > selftests: /linux/tools/testing/selftests/bpf: urandom_read > > ok 16 selftests: /linux/tools/testing/selftests/bpf: urandom_read > > > > selftests: /linux/tools/testing/selftests/bpf: sign-file > > not ok 17 selftests: /linux/tools/testing/selftests/bpf: sign-file # exit=2 > > > > Fixes: fc97590668ae ("selftests/bpf: Add test for bpf_verify_pkcs7_signature() kfunc") > > Signed-off-by: Alexey Gladkov <legion@kernel.org> > > Acked-by: Stanislav Fomichev <sdf@google.com>
Reviewed-by: Roberto Sassu <roberto.sassu@huawei.com>
Thanks
Roberto
> > --- > > tools/testing/selftests/bpf/Makefile | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile > > index b677dcd0b77a..fd214d1526d4 100644 > > --- a/tools/testing/selftests/bpf/Makefile > > +++ b/tools/testing/selftests/bpf/Makefile > > @@ -88,8 +88,7 @@ TEST_GEN_PROGS_EXTENDED = test_sock_addr test_skb_cgroup_id_user \ > > xskxceiver xdp_redirect_multi xdp_synproxy veristat xdp_hw_metadata \ > > xdp_features > > > > -TEST_CUSTOM_PROGS = $(OUTPUT)/urandom_read $(OUTPUT)/sign-file > > -TEST_GEN_FILES += liburandom_read.so > > +TEST_GEN_FILES += liburandom_read.so urandom_read sign-file > > > > # Emit succinct information message describing current building step > > # $1 - generic step name (e.g., CC, LINK, etc); > > -- > > 2.33.7 > >
| |