Messages in this thread | | | Subject | Re: [PATCH v2] wifi: ath9k: avoid referencing uninit memory in ath9k_wmi_ctrl_rx | From | Kalle Valo <> | Date | Fri, 28 Apr 2023 16:52:50 +0000 (UTC) |
| |
Fedor Pchelkin <pchelkin@ispras.ru> wrote:
> For the reasons also described in commit b383e8abed41 ("wifi: ath9k: avoid > uninit memory read in ath9k_htc_rx_msg()"), ath9k_htc_rx_msg() should > validate pkt_len before accessing the SKB. > > For example, the obtained SKB may have been badly constructed with > pkt_len = 8. In this case, the SKB can only contain a valid htc_frame_hdr > but after being processed in ath9k_htc_rx_msg() and passed to > ath9k_wmi_ctrl_rx() endpoint RX handler, it is expected to have a WMI > command header which should be located inside its data payload. > > Implement sanity checking inside ath9k_wmi_ctrl_rx(). Otherwise, uninit > memory can be referenced. > > Tested on Qualcomm Atheros Communications AR9271 802.11n . > > Found by Linux Verification Center (linuxtesting.org) with Syzkaller. > > Fixes: fb9987d0f748 ("ath9k_htc: Support for AR9271 chipset.") > Reported-and-tested-by: syzbot+f2cb6e0ffdb961921e4d@syzkaller.appspotmail.com > Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru> > Acked-by: Toke Høiland-Jørgensen <toke@toke.dk> > Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Patch applied to ath-next branch of ath.git, thanks.
f24292e82708 wifi: ath9k: avoid referencing uninit memory in ath9k_wmi_ctrl_rx
-- https://patchwork.kernel.org/project/linux-wireless/patch/20230424183348.111355-1-pchelkin@ispras.ru/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
| |