Messages in this thread | | | From | "Tian, Kevin" <> | Subject | RE: [PATCH V4 08/11] vfio/pci: Use bitfield for struct vfio_pci_core_device flags | Date | Fri, 28 Apr 2023 06:43:00 +0000 |
| |
> From: Chatre, Reinette <reinette.chatre@intel.com> > Sent: Friday, April 28, 2023 1:36 AM > > struct vfio_pci_core_device contains eleven boolean flags. > Boolean flags clearly indicate their usage but space usage > starts to be a concern when there are many. > > An upcoming change adds another boolean flag to > struct vfio_pci_core_device, thereby increasing the concern > that the boolean flags are consuming unnecessary space. > > Transition the boolean flags to use bitfields. On a system that > uses one byte per boolean this reduces the space consumed > by existing flags from 11 bytes to 2 bytes with room for > a few more flags without increasing the structure's size. > > Suggested-by: Jason Gunthorpe <jgg@nvidia.com> > Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
| |