Messages in this thread | | | From | "Gupta, Nipun" <> | Subject | RE: [PATCH v10 4/7] cdx: add MCDI protocol interface for firmware interaction | Date | Fri, 28 Apr 2023 10:53:11 +0000 |
| |
> -----Original Message----- > From: linux-arm-kernel <linux-arm-kernel-bounces@lists.infradead.org> On > Behalf Of Geert Uytterhoeven > Sent: Friday, April 28, 2023 1:44 PM > To: Gupta, Nipun <Nipun.Gupta@amd.com> > Cc: robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; > gregkh@linuxfoundation.org; rafael@kernel.org; eric.auger@redhat.com; > alex.williamson@redhat.com; cohuck@redhat.com; > song.bao.hua@hisilicon.com; mchehab+huawei@kernel.org; maz@kernel.org; > f.fainelli@gmail.com; jeffrey.l.hugo@gmail.com; saravanak@google.com; > Michael.Srba@seznam.cz; mani@kernel.org; yishaih@nvidia.com; > jgg@ziepe.ca; jgg@nvidia.com; robin.murphy@arm.com; will@kernel.org; > joro@8bytes.org; masahiroy@kernel.org; ndesaulniers@google.com; > rdunlap@infradead.org; baolu.lu@linux.intel.com; linux-arm- > kernel@lists.infradead.org; linux-kbuild@vger.kernel.org; linux- > kernel@vger.kernel.org; devicetree@vger.kernel.org; okaya@kernel.org; > Anand, Harpreet <harpreet.anand@amd.com>; Agarwal, Nikhil > <nikhil.agarwal@amd.com>; Simek, Michal <michal.simek@amd.com>; Jansen > Van Vuuren, Pieter <pieter.jansen-van-vuuren@amd.com>; Cascon, Pablo > <pablo.cascon@amd.com>; git (AMD-Xilinx) <git@amd.com> > Subject: Re: [PATCH v10 4/7] cdx: add MCDI protocol interface for firmware > interaction > > > Hi Nipun, > > On Mon, Mar 13, 2023 at 2:28 PM Nipun Gupta <nipun.gupta@amd.com> > wrote: > > The MCDI (Management CPU Driver Interface) is used as a > > protocol to communicate with the RPU firmware. It has > > pre-defined set of messages for different message exchanges > > between APU and RPU. > > > > Signed-off-by: Puneet Gupta <puneet.gupta@amd.com> > > Signed-off-by: Nipun Gupta <nipun.gupta@amd.com> > > Signed-off-by: Tarak Reddy <tarak.reddy@amd.com> > > Reviewed-by: Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@amd.com> > > Tested-by: Nikhil Agarwal <nikhil.agarwal@amd.com> > > Thanks for your patch, which is now commit eb96b740192b2a09 ("cdx: > add MCDI protocol interface for firmware interaction") upstream. > > > --- /dev/null > > +++ b/drivers/cdx/controller/Kconfig > > @@ -0,0 +1,20 @@ > > +# SPDX-License-Identifier: GPL-2.0-only > > +# > > +# CDX controller configuration > > +# > > +# Copyright (C) 2022-2023, Advanced Micro Devices, Inc. > > +# > > + > > +if CDX_BUS > > + > > +config MCDI_LOGGING > > + bool "MCDI Logging for the CDX controller" > > + depends on CDX_CONTROLLER > > + help > > + Enable MCDI Logging for > > + the CDX Controller for debug > > + purpose. > > + > > + If unsure, say N. > > + > > +endif > > As there also exist config symbols SFC_MCDI_LOGGING and > SFC_SIENA_MCDI_LOGGING, perhaps MCDI_LOGGING is too generic, and > should > be renamed to CDX_MCDI_LOGGING?
Sure, we will add a patch to rename this.
Thanks, Nipun
> > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux- > m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
| |