Messages in this thread Patch in this message | | | Date | Fri, 28 Apr 2023 06:50:27 +0100 | From | "Arnd Bergmann" <> | Subject | Re: [PATCH] mei: make hdcp and pxp depend on X86 && PCI |
| |
On Wed, Apr 26, 2023, at 19:11, Winkler, Tomas wrote: >> >> On Tue, Apr 25, 2023, at 16:27, Adam Borowski wrote: >> > The problem in mainline is inconsistency: out of 6 config items, 4 >> > repeat the "depends on X86 && PCI" line, the other 2 do not. There's >> > indeed no immediate functional issue, but I'd argue that a dormant bug is >> still a bug. > > The MEI protocol (CONFIG_INTEL_MEI) is not PCI or X86 dependent. > INTEL_MEI_GSC is PCI dependent but not X86. (Hope I correct also on > implementation side) > They HW layers are currently X86 dependent.
Ok, so in that case the dependencies should be relaxed like below I guess, in order to allow using the MEI on non-x86 i915 devices.
Arnd
diff --git a/drivers/misc/mei/Kconfig b/drivers/misc/mei/Kconfig index d21486d69df2..7c6e3b4588d0 100644 --- a/drivers/misc/mei/Kconfig +++ b/drivers/misc/mei/Kconfig @@ -2,7 +2,6 @@ # Copyright (c) 2003-2019, Intel Corporation. All rights reserved. config INTEL_MEI tristate "Intel Management Engine Interface" - depends on X86 && PCI help The Intel Management Engine (Intel ME) provides Manageability, Security and Media services for system containing Intel chipsets. @@ -39,7 +38,7 @@ config INTEL_MEI_ME config INTEL_MEI_TXE tristate "Intel Trusted Execution Environment with ME Interface" select INTEL_MEI - depends on X86 && PCI + depends on X86 help MEI Support for Trusted Execution Environment device on Intel SoCs @@ -50,7 +49,7 @@ config INTEL_MEI_GSC tristate "Intel MEI GSC embedded device" depends on INTEL_MEI depends on INTEL_MEI_ME - depends on X86 && PCI + depends on PCI depends on DRM_I915 help Intel auxiliary driver for GSC devices embedded in Intel graphics devices.
| |