Messages in this thread | | | Date | Fri, 28 Apr 2023 11:07:43 +0200 | From | Andi Shyti <> | Subject | Re: [Intel-gfx] [PATCH v8 2/2] drm/i915: Use correct huge page manager for MTL |
| |
Hi Andrzej,
> MTL currently uses gen8_ppgtt_insert_huge when managing huge pages. > This is because MTL reports as not supporting 64K pages, or more > accurately, the system that reports whether a platform has 64K pages > reports false for MTL. This is only half correct, as the 64K page support > reporting system only cares about 64K page support for LMEM, which MTL > doesn't have. > > MTL should be using xehpsdv_ppgtt_insert_huge. However, simply changing > over to using that manager doesn't resolve the issue because MTL is > expecting the virtual address space for the page table to be flushed after > initialization, so we must also add a flush statement there. > > Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com> > Reviewed-by: Matthew Auld <matthew.auld@intel.com> > Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Andi
| |