lkml.org 
[lkml]   [2023]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] HID: wacom: Added error check
On Thu, Apr 27, 2023 at 5:07 AM Denis Arefev <arefev@swemel.ru> wrote:
>
> Added a variable check and
> transition in case of an error
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Denis Arefev <arefev@swemel.ru>

Thank you Denis for working on the patch! The patch LGTM.

Reviewed-by: Ping Cheng <ping.cheng@wacom.com>

Cheers,
Ping

> ---
> drivers/hid/wacom_sys.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c
> index fb538a6c4add..aff4a21a46b6 100644
> --- a/drivers/hid/wacom_sys.c
> +++ b/drivers/hid/wacom_sys.c
> @@ -2417,8 +2417,13 @@ static int wacom_parse_and_register(struct wacom *wacom, bool wireless)
> goto fail_quirks;
> }
>
> - if (features->device_type & WACOM_DEVICETYPE_WL_MONITOR)
> + if (features->device_type & WACOM_DEVICETYPE_WL_MONITOR) {
> error = hid_hw_open(hdev);
> + if (error) {
> + hid_err(hdev, "hw open failed\n");
> + goto fail_quirks;
> + }
> + }
>
> wacom_set_shared_values(wacom_wac);
> devres_close_group(&hdev->dev, wacom);
> --
> 2.25.1
>

\
 
 \ /
  Last update: 2023-04-27 19:57    [W:4.048 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site