Messages in this thread | | | From | andy.shevchenko@gmail ... | Date | Wed, 26 Apr 2023 18:04:55 +0300 | Subject | Re: [PATCH v4 2/2] pinctrl: qcom: Add SDX75 pincontrol driver |
| |
Mon, Apr 24, 2023 at 02:33:50PM +0530, Rohit Agarwal kirjoitti: > Add initial Qualcomm SDX75 pinctrl driver to support pin configuration > with pinctrl framework for SDX75 SoC. > While at it, reordering the SDX65 entry.
...
> +#define FUNCTION(fname) \ > + [msm_mux_##fname] = { \ > + .name = #fname, \ > + .groups = fname##_groups, \ > + .ngroups = ARRAY_SIZE(fname##_groups), \ > + }
PINCTRL_PINFUNCTION() ?
...
> +static const struct of_device_id sdx75_pinctrl_of_match[] = { > + {.compatible = "qcom,sdx75-tlmm", .data = &sdx75_pinctrl}, {},
One entry per line. And drop comma in the terminator one.
> +};
No MODULE_DEVICE_TABLE()?
-- With Best Regards, Andy Shevchenko
| |