Messages in this thread | | | Date | Mon, 24 Apr 2023 16:52:25 +0100 | From | Mark Brown <> | Subject | Re: [PATCH] spi: davinci: Remove dead code in `davinci_spi_probe()` |
| |
On Mon, Apr 24, 2023 at 08:03:42PM +0800, Dongliang Mu wrote: > On 2023/4/24 19:48, Mark Brown wrote:
> > Is that check valid? 0 was a valid interrupt for some architectures...
> We just follow the comments of platform_get_irq().
> * Gets an IRQ for a platform device and prints an error message if finding > the > * IRQ fails. Device drivers should check the return value for errors so as > to > * not pass a negative integer value to the request_irq() APIs.
I'm not sure that's universally true yet, though there were some moves to try to get us there. arm, where this driver is used, was one of the platforms with 0 as a valid interrupt. [unhandled content-type:application/pgp-signature] | |