Messages in this thread | | | Date | Mon, 24 Apr 2023 08:33:46 -0700 | Subject | Re: [PATCH] ntb: hw: intel: remove return value check of `ndev_init_debugfs` | From | Dave Jiang <> |
| |
On 4/22/23 8:56 AM, Yinhao Hu wrote: > Smatch complains that: > ndev_init_debugfs() warn: 'ndev->debugfs_dir' is an error pointer or valid > > Debugfs checks are generally not supposed to be checked for errors > and it is not necessary here.
Can you please provide source on where this is true?
> > Just delete the dead code. > > Signed-off-by: Yinhao Hu <dddddd@hust.edu.cn> > Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn> > --- > The issue is found by static analysis and remains untested. > --- > drivers/ntb/hw/intel/ntb_hw_gen1.c | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/drivers/ntb/hw/intel/ntb_hw_gen1.c b/drivers/ntb/hw/intel/ntb_hw_gen1.c > index 9ab836d0d4f1..9b0b2c43f1bb 100644 > --- a/drivers/ntb/hw/intel/ntb_hw_gen1.c > +++ b/drivers/ntb/hw/intel/ntb_hw_gen1.c > @@ -778,13 +778,10 @@ static void ndev_init_debugfs(struct intel_ntb_dev *ndev) > ndev->debugfs_dir = > debugfs_create_dir(pci_name(ndev->ntb.pdev), > debugfs_dir); > - if (!ndev->debugfs_dir) > - ndev->debugfs_info = NULL; > - else > - ndev->debugfs_info = > - debugfs_create_file("info", S_IRUSR, > - ndev->debugfs_dir, ndev, > - &intel_ntb_debugfs_info); > + ndev->debugfs_info = > + debugfs_create_file("info", S_IRUSR, > + ndev->debugfs_dir, ndev, > + &intel_ntb_debugfs_info); > } > } >
| |