Messages in this thread | | | Date | Mon, 24 Apr 2023 22:07:35 +0800 | Subject | Re: [PATCH v10 2/2] drm: add kms driver for loongson display controller | From | Sui Jingfeng <> |
| |
Hi,
On 2023/4/4 22:10, Emil Velikov wrote: >> --- /dev/null >> +++ b/drivers/gpu/drm/loongson/lsdc_debugfs.c >> +void lsdc_debugfs_init(struct drm_minor *minor) >> +{ >> +#ifdef CONFIG_DEBUG_FS >> + drm_debugfs_create_files(lsdc_debugfs_list, >> + ARRAY_SIZE(lsdc_debugfs_list), >> + minor->debugfs_root, >> + minor); >> +#endif >> +} > Should probably build the file when debugfs is enabled and provide > no-op stub in the header. See nouveau for an example. > > It seem that the drm core already done this for us, are we really need those #ifdef guard anymore?
I remove all of the #ifdef CONFIG_DEBUG_FS in my program and disable the debugfs option in menuconfig
my driver compile without any error.
| |