lkml.org 
[lkml]   [2023]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] spi: remove return value check of debugfs_create_dir()
From
On 4/24/23 13:54, Mark Brown wrote:
> On Sun, Apr 23, 2023 at 02:11:54PM +0800, Yingsha Xu wrote:
>> Smatch complains that:
>> dw_spi_debugfs_init() warn: 'dws->debugfs' is an error pointer
>> or valid
>>
>> Debugfs checks are generally not supposed to be checked for errors
>> and it is not necessary here.
>>
>> Just delete the dead code.
>
> This is very much a question of taste with a range of use cases
> available.

No.
https://lkml.iu.edu/hypermail/linux/kernel/1901.2/05993.html
We can do things with the debug information without filesystem enabled.

\
 
 \ /
  Last update: 2023-04-24 15:28    [W:0.081 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site