Messages in this thread | | | Date | Mon, 24 Apr 2023 12:55:50 +0100 | From | Mark Brown <> | Subject | Re: [PATCH] drivers: regulator: core: remove return value check of `regulator_init` |
| |
On Sun, Apr 23, 2023 at 08:27:31PM +0800, Yuchen Yang wrote: > Smatch complains that: > regulator_init() warn: 'debugfs_root' is an error pointer or valid > > According to the documentation of the debugfs_create_dir() function, > there is no need to check the return value of this function. > Just delete the dead code.
This is very much a taste and use case question, you can't just delete error checks without thought.
> Fixes: 247514344492 ("regulator: Remove ifdefs for debugfs code")
Don't just throw random Fixes tags on things :( [unhandled content-type:application/pgp-signature] | |