Messages in this thread | | | Date | Mon, 24 Apr 2023 12:12:59 +0200 | Subject | Re: [PATCH v1 1/3] dt-bindings: iio: light: ROHM BU27008 | From | Krzysztof Kozlowski <> |
| |
On 21/04/2023 11:38, Matti Vaittinen wrote: > The ROHM BU27008 is a sensor with 5 photodiodes (red, green, blue, clear > and IR) with four configurable channels. Red and green being always > available and two out of the rest three (blue, clear, IR) can be > selected to be simultaneously measured. Typical application is adjusting > LCD backlight of TVs, mobile phones and tablet PCs. > > Add BU27008 dt-bindings. > > Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com> > --- > .../bindings/iio/light/rohm-bu27008.yaml | 49 +++++++++++++++++++ > 1 file changed, 49 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/light/rohm-bu27008.yaml
Filename like compatible, so rohm,bu27008.yaml
> > diff --git a/Documentation/devicetree/bindings/iio/light/rohm-bu27008.yaml b/Documentation/devicetree/bindings/iio/light/rohm-bu27008.yaml > new file mode 100644 > index 000000000000..d942c2817680 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/light/rohm-bu27008.yaml > @@ -0,0 +1,49 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/light/bu27008.yaml#
Does not look like you tested the bindings. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions).
> +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ROHM BU27008 color sensor > + > +maintainers: > + - Matti Vaittinen <mazziesaccount@gmail.com> > + > +description: |
Do not need '|' unless you need to preserve formatting.
> + The ROHM BU27008 is a sensor with 5 photodiodes (red, green, blue, clear > + and IR) with four configurable channels. Red and green being always > + available and two out of the rest three (blue, clear, IR) can be > + selected to be simultaneously measured. Typical application is adjusting > + LCD backlight of TVs, mobile phones and tablet PCs.
Best regards, Krzysztof
| |