Messages in this thread Patch in this message | | | From | "D. Starke" <> | Subject | [PATCH v3 3/8] tty: n_gsm: remove unneeded initialization of ret in gsm_dlci_config | Date | Mon, 24 Apr 2023 09:52:46 +0200 |
| |
From: Daniel Starke <daniel.starke@siemens.com>
The variable 'ret' is not used before assignment from gsm_activate_mux(). Still it gets initialized to zero at declaration.
Fix this as remarked in the link below by moving the declaration to the first assignment.
Link: https://lore.kernel.org/all/b42bc4d1-cc9d-d115-c981-aaa053bdc59f@kernel.org/
Signed-off-by: Daniel Starke <daniel.starke@siemens.com> --- drivers/tty/n_gsm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
v2 -> v3: No changes.
Link: https://lore.kernel.org/all/20230420085017.7314-4-daniel.starke@siemens.com/
diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c index 00f692e2e810..9a2cf3e14678 100644 --- a/drivers/tty/n_gsm.c +++ b/drivers/tty/n_gsm.c @@ -3277,7 +3277,6 @@ static void gsm_copy_config_values(struct gsm_mux *gsm, static int gsm_config(struct gsm_mux *gsm, struct gsm_config *c) { - int ret = 0; int need_close = 0; int need_restart = 0; @@ -3356,7 +3355,7 @@ static int gsm_config(struct gsm_mux *gsm, struct gsm_config *c) * and removing from the mux array */ if (gsm->dead) { - ret = gsm_activate_mux(gsm); + int ret = gsm_activate_mux(gsm); if (ret) return ret; if (gsm->initiator) -- 2.34.1
| |