Messages in this thread | | | Date | Tue, 25 Apr 2023 12:55:02 +0900 | From | Masami Hiramatsu (Google) <> | Subject | Re: [PATCH v11 8/8] selftests/ftrace: Add funcgraph-retval test case |
| |
On Sat, 8 Apr 2023 05:42:22 -0700 Donglin Peng <pengdonglin@sangfor.com.cn> wrote:
> Add a test case for the funcgraph-retval and funcgraph-retval-hex > trace options. >
This looks good to me.
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Thank you!
> Signed-off-by: Donglin Peng <pengdonglin@sangfor.com.cn> > --- > v11: > - Fix selftest issues > > v10: > - Fix issues in selftest > > v8: > - Fix issues in selftest > --- > .../ftrace/test.d/ftrace/fgraph-retval.tc | 44 +++++++++++++++++++ > 1 file changed, 44 insertions(+) > create mode 100644 tools/testing/selftests/ftrace/test.d/ftrace/fgraph-retval.tc > > diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/fgraph-retval.tc b/tools/testing/selftests/ftrace/test.d/ftrace/fgraph-retval.tc > new file mode 100644 > index 000000000000..e34c0bdef3ed > --- /dev/null > +++ b/tools/testing/selftests/ftrace/test.d/ftrace/fgraph-retval.tc > @@ -0,0 +1,44 @@ > +#!/bin/sh > +# SPDX-License-Identifier: GPL-2.0 > +# description: ftrace - function graph print function return value > +# requires: options/funcgraph-retval options/funcgraph-retval-hex function_graph:tracer > + > +# Make sure that funcgraph-retval works > + > +fail() { # msg > + echo $1 > + exit_fail > +} > + > +disable_tracing > +clear_trace > + > +# get self PID, can not use $$, because it is PPID > +read PID _ < /proc/self/stat > + > +[ -f set_ftrace_filter ] && echo proc_reg_write > set_ftrace_filter > +[ -f set_ftrace_pid ] && echo ${PID} > set_ftrace_pid > +echo function_graph > current_tracer > +echo 1 > options/funcgraph-retval > + > +set +e > +enable_tracing > +echo > /proc/interrupts > +disable_tracing > +set -e > + > +: "Test printing the error code in signed decimal format" > +echo 0 > options/funcgraph-retval-hex > +count=`cat trace | grep 'proc_reg_write' | grep '= -5' | wc -l` > +if [ $count -eq 0 ]; then > + fail "Return value can not be printed in signed decimal format" > +fi > + > +: "Test printing the error code in hexadecimal format" > +echo 1 > options/funcgraph-retval-hex > +count=`cat trace | grep 'proc_reg_write' | grep 'fffffffb' | wc -l` > +if [ $count -eq 0 ]; then > + fail "Return value can not be printed in hexadecimal format" > +fi > + > +exit 0 > -- > 2.25.1 >
-- Masami Hiramatsu (Google) <mhiramat@kernel.org>
| |