Messages in this thread | | | Subject | Re: [PATCH] scsi: ipr: remove several unused variables | From | "Martin K. Petersen" <> | Date | Mon, 24 Apr 2023 23:12:52 -0400 |
| |
Tom,
> gcc with W=1 reports > drivers/scsi/ipr.c: In function ‘ipr_init_res_entry’: > drivers/scsi/ipr.c:1104:22: error: variable ‘proto’ > set but not used [-Werror=unused-but-set-variable] > 1104 | unsigned int proto; > | ^~~~~ > drivers/scsi/ipr.c: In function ‘ipr_update_res_entry’: > drivers/scsi/ipr.c:1261:22: error: variable ‘proto’ > set but not used [-Werror=unused-but-set-variable] > 1261 | unsigned int proto; > | ^~~~~ > drivers/scsi/ipr.c: In function ‘ipr_change_queue_depth’: > drivers/scsi/ipr.c:4417:36: error: variable ‘res’ > set but not used [-Werror=unused-but-set-variable] > 4417 | struct ipr_resource_entry *res; > | ^~~ > > These variables are not used, so remove them. > The lock around res is not needed so remove that. > Which makes ioa_cfg and lock_flags unneeded so remove them.
Applied to 6.4/scsi-staging, thanks!
-- Martin K. Petersen Oracle Linux Engineering
| |