lkml.org 
[lkml]   [2023]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH RESEND] usb: dwc3: remove dead code in dwc3_otg_get_irq
From

On 2023/4/25 05:33, 'Thinh Nguyen' via HUST OS Kernel Contribution wrote:
> On Mon, Apr 24, 2023, lihuya wrote:
>> platform_get_irq() only return non-zero irq number on success, or
>> negative error number on failure.
>>
>> There is no need to check the return value of platform_get_irq()
>> to determine the return value of dwc3_otg_get_irq(), removing
>> them to solve this problem.
>>
>> Signed-off-by: lihuya <lihuya@hust.edu.cn>
> Is this your full name?

Hi Yuhang,

Please use your full name: Yuhang Liang. This is essential in the kernel
patch submission.

Dongliang Mu

>
>> ---
>> drivers/usb/dwc3/drd.c | 5 -----
>> 1 file changed, 5 deletions(-)
>>
>> diff --git a/drivers/usb/dwc3/drd.c b/drivers/usb/dwc3/drd.c
>> index 039bf241769a..c2e09700212d 100644
>> --- a/drivers/usb/dwc3/drd.c
>> +++ b/drivers/usb/dwc3/drd.c
>> @@ -154,11 +154,6 @@ static int dwc3_otg_get_irq(struct dwc3 *dwc)
>> goto out;
>>
>> irq = platform_get_irq(dwc3_pdev, 0);
>> - if (irq > 0)
>> - goto out;
>> -
>> - if (!irq)
>> - irq = -EINVAL;
>>
>> out:
>> return irq;
>> --
>> 2.34.1
>>
> FWIW, here's the ack again.
>
> Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
>
> Thanks,
> Thinh
>

\
 
 \ /
  Last update: 2023-04-25 01:31    [W:0.054 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site