Messages in this thread | | | Date | Fri, 21 Apr 2023 15:02:30 -0700 | From | Luis Chamberlain <> | Subject | Re: [PATCH 3/5] iomap: simplify iomap_init() with PAGE_SECTORS |
| |
On Fri, Apr 21, 2023 at 09:14:00PM +0100, Matthew Wilcox wrote: > On Fri, Apr 21, 2023 at 12:58:05PM -0700, Luis Chamberlain wrote: > > Just use the PAGE_SECTORS generic define. This produces no functional > > changes. While at it use left shift to simplify this even further. > > How is FOO << 2 simpler than FOO * 4? > > > - return bioset_init(&iomap_ioend_bioset, 4 * (PAGE_SIZE / SECTOR_SIZE), > > + return bioset_init(&iomap_ioend_bioset, PAGE_SECTORS << 2,
We could just do:
- return bioset_init(&iomap_ioend_bioset, 4 * (PAGE_SIZE / SECTOR_SIZE), + return bioset_init(&iomap_ioend_bioset, 4 * PAGE_SECTORS,
The shift just seemed optimal if we're just going to change it.
Luis
| |