Messages in this thread | | | Subject | Re: [PATCH] ext4: Fix unused iterator variable warnings | From | Jason Yan <> | Date | Fri, 21 Apr 2023 09:52:37 +0800 |
| |
On 2023/4/21 0:51, Nathan Chancellor wrote: > When CONFIG_QUOTA is disabled, there are warnings around unused iterator > variables: > > fs/ext4/super.c: In function 'ext4_put_super': > fs/ext4/super.c:1262:13: error: unused variable 'i' [-Werror=unused-variable] > 1262 | int i, err; > | ^ > fs/ext4/super.c: In function '__ext4_fill_super': > fs/ext4/super.c:5200:22: error: unused variable 'i' [-Werror=unused-variable] > 5200 | unsigned int i; > | ^ > cc1: all warnings being treated as errors > > The kernel has updated to gnu11, allowing the variables to be declared > within the for loop. Do so to clear up the warnings. > > Fixes: dcbf87589d90 ("ext4: factor out ext4_flex_groups_free()") > Signed-off-by: Nathan Chancellor<nathan@kernel.org> > --- > fs/ext4/super.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-)
Thanks for the fix:
Reviewed-by: Jason Yan <yanaijie@huawei.com>
| |