Messages in this thread | | | Date | Wed, 19 Apr 2023 20:55:35 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH 2/2] edac: cpc925: Use of_get_cpu_hwid() to read CPU node 'reg' |
| |
On Wed, Apr 19, 2023 at 01:45:47PM -0500, Rob Herring wrote: > I'd rather not export of_get_cpu_hwid() which is otherwise only used in > arch code. I think I'll rewrite this in terms of for_each_possible_cpu() > and topology_core_id(). Though that would make a UP build not enable > core 1, but that seems undesirable anyways.
TBH I'm not sure this driver is even worth any effort besides simply deleting it. I see one commit which reads like someone was really using it:
ce395088832b ("cpc925_edac: Support single-processor configurations")
but that one is from 2011 and since then it has received only API modifications/cleanups.
But if I delete it, someone might crawl out of the woodwork and say it is still used...
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |