lkml.org 
[lkml]   [2023]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] posix-cpu-timers: Implement the missing timer_wait_running callback
    Date
    On Tue, Apr 18 2023 at 18:44, Frederic Weisbecker wrote:
    > Le Mon, Apr 17, 2023 at 03:37:55PM +0200, Thomas Gleixner a écrit :
    >> struct cpu_timer {
    >> struct timerqueue_node node;
    >> @@ -72,6 +74,7 @@ struct cpu_timer {
    >> struct pid *pid;
    >> struct list_head elist;
    >> int firing;
    >> + struct task_struct *handling;
    >
    > I guess it can be made __rcu

    Indeed.
    >> if (likely(cpu_firing >= 0))
    >> cpu_timer_fire(timer);
    >> + /* See posix_cpu_timer_wait_running() */
    >> + WRITE_ONCE(timer->it.cpu.handling, NULL);
    >
    > And rcu_assign_pointer()

    I fix that up on the fly.

    > Aside the boring details:
    >
    > Reviewed-by: Frederic Weisbecker <frederic@kernel.org>

    Thanks for going through this!

    \
     
     \ /
      Last update: 2023-04-19 09:33    [W:3.241 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site