Messages in this thread | | | Date | Thu, 20 Apr 2023 01:15:03 +0300 | Subject | Re: [PATCH 01/11] drm/msm/dpu: tweak msm8998 hw catalog values | From | Dmitry Baryshkov <> |
| |
On 19/04/2023 17:41, Arnaud Vrac wrote: > Match the values found in the downstream msm-4.4 kernel sde driver. > > Signed-off-by: Arnaud Vrac <avrac@freebox.fr>
Fixes: 94391a14fc27 ("drm/msm/dpu1: Add MSM8998 to hw catalog")
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> --- > drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h | 8 ++++---- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 15 +++++---------- > 2 files changed, 9 insertions(+), 14 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h > index 2b3ae84057dfe..b07e8a9941f79 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h > +++ b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h > @@ -134,10 +134,10 @@ static const struct dpu_dspp_cfg msm8998_dspp[] = { > }; > > static const struct dpu_intf_cfg msm8998_intf[] = { > - INTF_BLK("intf_0", INTF_0, 0x6a000, 0x280, INTF_DP, 0, 25, INTF_SDM845_MASK, MDP_SSPP_TOP0_INTR, 24, 25), > - INTF_BLK("intf_1", INTF_1, 0x6a800, 0x280, INTF_DSI, 0, 25, INTF_SDM845_MASK, MDP_SSPP_TOP0_INTR, 26, 27), > - INTF_BLK("intf_2", INTF_2, 0x6b000, 0x280, INTF_DSI, 1, 25, INTF_SDM845_MASK, MDP_SSPP_TOP0_INTR, 28, 29), > - INTF_BLK("intf_3", INTF_3, 0x6b800, 0x280, INTF_HDMI, 0, 25, INTF_SDM845_MASK, MDP_SSPP_TOP0_INTR, 30, 31), > + INTF_BLK("intf_0", INTF_0, 0x6a000, 0x280, INTF_DP, 0, 21, INTF_SDM845_MASK, MDP_SSPP_TOP0_INTR, 24, 25), > + INTF_BLK("intf_1", INTF_1, 0x6a800, 0x280, INTF_DSI, 0, 21, INTF_SDM845_MASK, MDP_SSPP_TOP0_INTR, 26, 27), > + INTF_BLK("intf_2", INTF_2, 0x6b000, 0x280, INTF_DSI, 1, 21, INTF_SDM845_MASK, MDP_SSPP_TOP0_INTR, 28, 29), > + INTF_BLK("intf_3", INTF_3, 0x6b800, 0x280, INTF_HDMI, 0, 21, INTF_SDM845_MASK, MDP_SSPP_TOP0_INTR, 30, 31), > }; > > static const struct dpu_perf_cfg msm8998_perf_data = { > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c > index 03f162af1a50b..8d5d782a43398 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c > @@ -587,12 +587,12 @@ static const u32 sdm845_nrt_pri_lvl[] = {3, 3, 3, 3, 3, 3, 3, 3}; > > static const struct dpu_vbif_dynamic_ot_cfg msm8998_ot_rdwr_cfg[] = { > { > - .pps = 1088 * 1920 * 30, > + .pps = 1920 * 1080 * 30, > .ot_limit = 2, > }, > { > - .pps = 1088 * 1920 * 60, > - .ot_limit = 6, > + .pps = 1920 * 1080 * 60, > + .ot_limit = 4, > }, > { > .pps = 3840 * 2160 * 30, > @@ -705,10 +705,7 @@ static const struct dpu_qos_lut_entry msm8998_qos_linear[] = { > {.fl = 10, .lut = 0x1555b}, > {.fl = 11, .lut = 0x5555b}, > {.fl = 12, .lut = 0x15555b}, > - {.fl = 13, .lut = 0x55555b}, > - {.fl = 14, .lut = 0}, > - {.fl = 1, .lut = 0x1b}, > - {.fl = 0, .lut = 0} > + {.fl = 0, .lut = 0x55555b} > }; > > static const struct dpu_qos_lut_entry sdm845_qos_linear[] = { > @@ -730,9 +727,7 @@ static const struct dpu_qos_lut_entry msm8998_qos_macrotile[] = { > {.fl = 10, .lut = 0x1aaff}, > {.fl = 11, .lut = 0x5aaff}, > {.fl = 12, .lut = 0x15aaff}, > - {.fl = 13, .lut = 0x55aaff}, > - {.fl = 1, .lut = 0x1aaff}, > - {.fl = 0, .lut = 0}, > + {.fl = 0, .lut = 0x55aaff}, > }; > > static const struct dpu_qos_lut_entry sc7180_qos_linear[] = { >
-- With best wishes Dmitry
| |