lkml.org 
[lkml]   [2023]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] tracing/timer: Add missing hrtimer modes to decode_hrtimer_mode().
From


On 4/18/2023 8:08 PM, Sebastian Andrzej Siewior wrote:
> The trace output for the HRTIMER_MODE_.*_HARD modes is seen as a number
> since these modes are not decoded. The author was not aware of the fancy
> decoding function which makes the life easier.
>
> Extend decode_hrtimer_mode() with the additional HRTIMER_MODE_.*_HARD
> modes.
>
> Fixes: ae6683d815895 ("hrtimer: Introduce HARD expiry mode")
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

Good catch.
Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>

-Mukesh

> ---
> include/trace/events/timer.h | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/include/trace/events/timer.h b/include/trace/events/timer.h
> index 2e713a7d9aa3a..5d43751a766c6 100644
> --- a/include/trace/events/timer.h
> +++ b/include/trace/events/timer.h
> @@ -158,7 +158,11 @@ DEFINE_EVENT(timer_class, timer_cancel,
> { HRTIMER_MODE_ABS_SOFT, "ABS|SOFT" }, \
> { HRTIMER_MODE_REL_SOFT, "REL|SOFT" }, \
> { HRTIMER_MODE_ABS_PINNED_SOFT, "ABS|PINNED|SOFT" }, \
> - { HRTIMER_MODE_REL_PINNED_SOFT, "REL|PINNED|SOFT" })
> + { HRTIMER_MODE_REL_PINNED_SOFT, "REL|PINNED|SOFT" }, \
> + { HRTIMER_MODE_ABS_HARD, "ABS|HARD" }, \
> + { HRTIMER_MODE_REL_HARD, "REL|HARD" }, \
> + { HRTIMER_MODE_ABS_PINNED_HARD, "ABS|PINNED|HARD" }, \
> + { HRTIMER_MODE_REL_PINNED_HARD, "REL|PINNED|HARD" })
>
> /**
> * hrtimer_init - called when the hrtimer is initialized

\
 
 \ /
  Last update: 2023-04-18 17:25    [W:0.096 / U:0.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site