Messages in this thread | | | Date | Mon, 17 Apr 2023 12:55:30 +0200 | Subject | Re: [PATCH v3 1/7] mm/gup: remove unused vmas parameter from get_user_pages() | From | David Hildenbrand <> |
| |
On 15.04.23 14:09, Lorenzo Stoakes wrote: > No invocation of get_user_pages() uses the vmas parameter, so remove > it. > > The GUP API is confusing and caveated. Recent changes have done much to > improve that, however there is more we can do. Exporting vmas is a prime > target as the caller has to be extremely careful to preclude their use > after the mmap_lock has expired or otherwise be left with dangling > pointers. > > Removing the vmas parameter focuses the GUP functions upon their primary > purpose - pinning (and outputting) pages as well as performing the actions > implied by the input flags. > > This is part of a patch series aiming to remove the vmas parameter > altogether. > > Signed-off-by: Lorenzo Stoakes <lstoakes@gmail.com> > Suggested-by: Matthew Wilcox (Oracle) <willy@infradead.org> > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > ---
Acked-by: David Hildenbrand <david@redhat.com>
-- Thanks,
David / dhildenb
| |