lkml.org 
[lkml]   [2023]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 02/19] arch/arc: Implement <asm/fb.h> with generic helpers
From


Am 06.04.23 um 16:43 schrieb Arnd Bergmann:
> On Thu, Apr 6, 2023, at 16:30, Thomas Zimmermann wrote:
>> +
>> static inline void fb_pgprotect(struct file *file, struct vm_area_struct *vma,
>> unsigned long off)
>> {
>> vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);
>> }
>> +#define fb_pgprotect fb_pgprotect
>
> I still feel that for architectures like arc that don't have
> pgprot_writecombine(), it would b best to go with the
> generic implementation that currently behaves the exact
> same way. If pgprot_writecombine() gets added in the future,
> it would cause the architecture to behave as expected rather
> than introducing the same bug that mips has.

OK, I'll change it.

>
> Arnd

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2023-04-17 11:06    [W:0.043 / U:0.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site