Messages in this thread | | | Date | Mon, 17 Apr 2023 09:05:34 +0100 | Subject | Re: [PATCH] media: ov5693: Simplify an error message | From | Dan Scally <> |
| |
Hi Christophe
On 15/04/2023 17:28, Christophe JAILLET wrote: > dev_err_probe() already display the error code. There is no need to > duplicate it explicitly in the error message. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > ---
Thanks for the patch:
Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
> drivers/media/i2c/ov5693.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/i2c/ov5693.c b/drivers/media/i2c/ov5693.c > index e3c3bed69ad6..d23786afd754 100644 > --- a/drivers/media/i2c/ov5693.c > +++ b/drivers/media/i2c/ov5693.c > @@ -404,8 +404,8 @@ static int ov5693_read_reg(struct ov5693_device *ov5693, u32 addr, u32 *value) > ret = i2c_transfer(client->adapter, msg, 2); > if (ret < 0) > return dev_err_probe(&client->dev, ret, > - "Failed to read register 0x%04x: %d\n", > - addr & OV5693_REG_ADDR_MASK, ret); > + "Failed to read register 0x%04x\n", > + addr & OV5693_REG_ADDR_MASK); > > *value = 0; > for (i = 0; i < len; ++i) {
| |