Messages in this thread | | | Date | Mon, 17 Apr 2023 17:12:15 -0400 | Subject | Re: [PATCH 1/2] drm/amd/display: mark dccg314_init() static | From | Hamza Mahfooz <> |
| |
On 4/17/23 17:05, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > The newly introduced global function is not declared in a header or > called from another file, causing a harmless warning with sparse > or W=1 builds: > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn314/dcn314_dccg.c:277:6: error: no previous prototype for 'dccg314_init' [-Werror=missing-prototypes] > > Mark it static instead. > > Fixes: 6f6869dcf415 ("drm/amd/display: prep work for root clock optimization enablement for DCN314") > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
This has already been fixed as of commit 669f4ac40947 ("drm/amd/display: set variable dccg314_init storage-class-specifier to static") in amd-staging-drm-next.
> --- > drivers/gpu/drm/amd/display/dc/dcn314/dcn314_dccg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_dccg.c b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_dccg.c > index 6f879265ad9c..de7bfba2c179 100644 > --- a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_dccg.c > +++ b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_dccg.c > @@ -274,7 +274,7 @@ static void dccg314_set_dpstreamclk( > } > } > > -void dccg314_init(struct dccg *dccg) > +static void dccg314_init(struct dccg *dccg) > { > int otg_inst; > -- Hamza
| |