lkml.org 
[lkml]   [2023]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2] USB: serial: option: add UNISOC vendor and TOZED LT70C product
From
On 17.04.2023 19:06, Johan Hovold wrote:
> On Mon, Apr 17, 2023 at 06:20:03PM +0300, arinc9.unal@gmail.com wrote:
>> From: Arınç ÜNAL <arinc.unal@arinc9.com>
>>
>> Add UNISOC vendor ID and TOZED LT70-C modem which is based from UNISOC
>> SL8563. The modem supports the NCM mode. Interface 0 is used for running
>> the AT commands. Interface 12 is the ADB interface.
>>
>> T: Bus=01 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 6 Spd=480 MxCh= 0
>> D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1
>> P: Vendor=1782 ProdID=4055 Rev=04.04
>> S: Manufacturer=Unisoc Phone
>> S: Product=Unisoc Phone
>> S: SerialNumber=<redacted>
>> C: #Ifs=14 Cfg#= 1 Atr=c0 MxPwr=500mA
>> I: If#= 0 Alt= 0 #EPs= 1 Cls=02(commc) Sub=0d Prot=00 Driver=cdc_ncm
>> E: Ad=82(I) Atr=03(Int.) MxPS= 16 Ivl=32ms
>> I: If#= 1 Alt= 1 #EPs= 2 Cls=0a(data ) Sub=00 Prot=01 Driver=cdc_ncm
>> E: Ad=01(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>> E: Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>> I: If#=10 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
>> E: Ad=07(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>> E: Ad=8b(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>> I: If#=11 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
>> E: Ad=08(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>> E: Ad=8c(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>> I: If#=12 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=42 Prot=01 Driver=option
>
> I changed this to:
>
> I: If#=12 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=42 Prot=01 Driver=(none)
>
>> E: Ad=09(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>> E: Ad=8d(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>> I: If#=13 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
>> E: Ad=0a(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>> E: Ad=8e(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>> I: If#= 2 Alt= 0 #EPs= 1 Cls=02(commc) Sub=0d Prot=00 Driver=cdc_ncm
>> E: Ad=84(I) Atr=03(Int.) MxPS= 16 Ivl=32ms
>> I: If#= 3 Alt= 1 #EPs= 2 Cls=0a(data ) Sub=00 Prot=01 Driver=cdc_ncm
>> E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>> E: Ad=83(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>> I: If#= 4 Alt= 0 #EPs= 1 Cls=02(commc) Sub=0d Prot=00 Driver=cdc_ncm
>> E: Ad=86(I) Atr=03(Int.) MxPS= 16 Ivl=32ms
>> I: If#= 5 Alt= 1 #EPs= 2 Cls=0a(data ) Sub=00 Prot=01 Driver=cdc_ncm
>> E: Ad=03(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>> E: Ad=85(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>> I: If#= 6 Alt= 0 #EPs= 1 Cls=02(commc) Sub=0d Prot=00 Driver=cdc_ncm
>> E: Ad=88(I) Atr=03(Int.) MxPS= 16 Ivl=32ms
>> I: If#= 7 Alt= 1 #EPs= 2 Cls=0a(data ) Sub=00 Prot=01 Driver=cdc_ncm
>> E: Ad=04(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>> E: Ad=87(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>> I: If#= 8 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
>> E: Ad=05(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>> E: Ad=89(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>> I: If#= 9 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
>> E: Ad=06(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>> E: Ad=8a(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
>>
>> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
>> ---
>
> Next time, remember to include a brief changelog here when respinning.
>
> Now applied, thanks.

Thanks a lot. I just realised I made a slight mistake on the comment
line, calling the modem TL70-C instead of LT70-C. Would you take another
patch for this or apply a potential v3 instead?

Arınç

\
 
 \ /
  Last update: 2023-04-17 22:20    [W:0.114 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site