Messages in this thread | | | From | Stanislav Fomichev <> | Date | Thu, 13 Apr 2023 09:37:09 -0700 | Subject | Re: [PATCH net-next v4 2/4] net: socket: add sockopts blacklist for BPF cgroup hook |
| |
On Thu, Apr 13, 2023 at 7:38 AM Aleksandr Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com> wrote: > > On Thu, Apr 13, 2023 at 4:22 PM Eric Dumazet <edumazet@google.com> wrote: > > > > On Thu, Apr 13, 2023 at 3:35 PM Alexander Mikhalitsyn > > <aleksandr.mikhalitsyn@canonical.com> wrote: > > > > > > During work on SO_PEERPIDFD, it was discovered (thanks to Christian), > > > that bpf cgroup hook can cause FD leaks when used with sockopts which > > > install FDs into the process fdtable. > > > > > > After some offlist discussion it was proposed to add a blacklist of > > > > We try to replace this word by either denylist or blocklist, even in changelogs. > > Hi Eric, > > Oh, I'm sorry about that. :( Sure. > > > > > > socket options those can cause troubles when BPF cgroup hook is enabled. > > > > > > > Can we find the appropriate Fixes: tag to help stable teams ? > > Sure, I will add next time. > > Fixes: 0d01da6afc54 ("bpf: implement getsockopt and setsockopt hooks") > > I think it's better to add Stanislav Fomichev to CC.
Can we use 'struct proto' bpf_bypass_getsockopt instead? We already use it for tcp zerocopy, I'm assuming it should work in this case as well?
> Kind regards, > Alex > > > > > > Cc: "David S. Miller" <davem@davemloft.net> > > > Cc: Eric Dumazet <edumazet@google.com> > > > Cc: Jakub Kicinski <kuba@kernel.org> > > > Cc: Paolo Abeni <pabeni@redhat.com> > > > Cc: Leon Romanovsky <leon@kernel.org> > > > Cc: David Ahern <dsahern@kernel.org> > > > Cc: Arnd Bergmann <arnd@arndb.de> > > > Cc: Kees Cook <keescook@chromium.org> > > > Cc: Christian Brauner <brauner@kernel.org> > > > Cc: Kuniyuki Iwashima <kuniyu@amazon.com> > > > Cc: Lennart Poettering <mzxreary@0pointer.de> > > > Cc: linux-kernel@vger.kernel.org > > > Cc: netdev@vger.kernel.org > > > Cc: linux-arch@vger.kernel.org > > > Suggested-by: Daniel Borkmann <daniel@iogearbox.net> > > > Suggested-by: Christian Brauner <brauner@kernel.org> > > > Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com> > > > > Thanks.
| |