Messages in this thread | | | Date | Thu, 13 Apr 2023 18:15:53 +0200 | Subject | Re: [PATCH 4/4] arm64: dts: qcom: sa8775p: pmic: add the sdam_0 node | From | Krzysztof Kozlowski <> |
| |
On 13/04/2023 15:17, Bartosz Golaszewski wrote: > From: Parikshit Pareek <quic_ppareek@quicinc.com> > > Introduce sdam_0 node, which is to be used via nvmem for power on > reasons during reboot. Add supported PoN reaons supported via sdam_0 > node. > > Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > --- > arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi > index 5abdc239d3a6..49bf7b08f5b6 100644 > --- a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi > +++ b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi > @@ -88,6 +88,14 @@ trip1 { > }; > }; > }; > + > + reboot_reason {
No underscores in node names. This is almost always called reboot-mode. Please, do not use downstream naming and conventions.
> + compatible = "nvmem-reboot-mode"; > + nvmem-cells = <&reboot_reason>; > + nvmem-cell-names = "reboot-mode"; > + mode-recovery = <0x01>; > + mode-bootloader = <0x02>; > + }; > }; Best regards, Krzysztof
| |