Messages in this thread | | | Date | Thu, 13 Apr 2023 17:07:00 +0200 (CEST) | From | Jiri Kosina <> | Subject | Re: [PATCH v2 1/1] HID: shield: Initial driver implementation with Thunderstrike support |
| |
On Mon, 10 Apr 2023, Rahul Rameshbabu wrote:
> Supports the Thunderstrike (SHIELD 2017) controller. Implements support for > the Thunderstrike HOSTCMD firmware interface. Adds sysfs attributes about a > SHIELD device and introduces haptics support for controllers. > > Signed-off-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
Thanks a lot for submitting the driver. I have one minor question:
[ ... snip ... ] > +thunderstrike_update_haptics(struct thunderstrike *ts, > + struct thunderstrike_hostcmd_haptics *motors) > +{ > + unsigned long flags; > + > + spin_lock_irqsave(&ts->haptics_update_lock, flags); > + ts->haptics_val = *motors; > + spin_unlock_irqrestore(&ts->haptics_update_lock, flags);
Do we really have to disable interrupts when taking haptics_update_lock? Is it ever being taken from interrupt context?
Thanks,
-- Jiri Kosina SUSE Labs
| |