lkml.org 
[lkml]   [2023]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [net-next PATCH v6 06/16] net: phy: phy_device: Call into the PHY driver to set LED brightness
    From


    On 3/27/2023 7:10 AM, Christian Marangi wrote:
    > From: Andrew Lunn <andrew@lunn.ch>
    >
    > Linux LEDs can be software controlled via the brightness file in /sys.
    > LED drivers need to implement a brightness_set function which the core
    > will call. Implement an intermediary in phy_device, which will call
    > into the phy driver if it implements the necessary function.
    >
    > Signed-off-by: Andrew Lunn <andrew@lunn.ch>
    > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>

    Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

    > + int (*led_brightness_set)(struct phy_device *dev,
    > + u32 index, enum led_brightness value);

    I think I would have made this an u8, 4 billion LEDs, man, that's a lot!
    --
    Florian

    \
     
     \ /
      Last update: 2023-04-13 19:07    [W:4.342 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site